Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#3640 closed defect (fixed)

Epic discharge billing diagnosis modifier "Present on admission" will incorrectly return 0 patients

Reported by: rwaitman Owned by: ngraham
Priority: major Milestone: heron-riverwalk-update
Component: data-repository Keywords: wrong-results public-web
Cc: vleonardo, mhoag, dconnolly, tmcmahon Blocked By: 3082
Blocking: 3676 Sensitive: no


In #3082, we added Epic billing diagnosis. While reviewing the code I realized that "Present on admission" modifier under "Billing Diagnosis - Discharge" is gets loaded in the terms tree (and is therefore visible to users) but the associated facts don't get loaded. The other billing diagnosis modifier facts should get loaded correctly however.

See ticket:3082#comment:32 for a screenshot of the hierarchy. See ticket:3082#comment:31 for finding the relevant data in Clarity.

Making Russ the reporter since he's the customer on the original feature.

Change History (10)

comment:1 Changed 3 years ago by mhoag

  • Blocking set to 3677

comment:2 Changed 3 years ago by ngraham

  • Status changed from new to accepted

comment:3 Changed 3 years ago by ngraham

  • Blocking changed from 3677 to 3676

This actually blocks ETL.

comment:4 Changed 3 years ago by ngraham

  • Owner changed from ngraham to mhoag
  • Status changed from accepted to assigned

Failing test case added in [ae15778241b1]. Update test data so we have one discharge DX flagged as POA [7191eed0e193]. Fixed in [c961c2ec9a6d].

I plan to test it on DEV_SERVER once it's available. Matt agreed to review the epic_poa_discharge_dx_3640 branch.

comment:5 Changed 3 years ago by ngraham


My first attempt at modifying test data to result in a POA fact failed as I didn't end up picking an encounter that got mapped in HERON. I fixed the test data - see [4c7aa32e1829].

Ran heron_etl_tiny_no_DBA/1010. Now, the test passes:

python --demo
INFO:__main__:opening Heron homepage...
INFO:__main__:Found page with title: i2b2 Web Client
INFO:__main__:Getting user configuration...
INFO:__main__:Got it.
Testing: Billing Diagnosis - Present on Admission
INFO:__main__:Found: 1
INFO:__main__:timing: 2015-08-13 10:53:58.089000, 2015-08-13 10:54:03.652000, 0:00:05.563000

comment:6 Changed 3 years ago by ngraham

  • Owner changed from mhoag to schandaka

Matt is pretty busy now with Flowsheet deid just now - Sravani agreed to review instead.

comment:7 Changed 3 years ago by schandaka

  • Owner changed from schandaka to ngraham

Nathan briefly walked me through the code and it is pretty straight forward.

Feature Checklist

Item Ready?
Use Case Clear? Yes
Automated Feature Tests? Yes
Usable by Peer Developers? Yes
Code Secure? N/A
Performance OK? Not Checked(Will check with Nathan about this)
Deployment OK? N/A
Copyright and Acknowledgements? Yes
Happy to Maintain? Yes

Assigning this back to Nathan.

comment:8 Changed 3 years ago by ngraham

  • Resolution set to fixed
  • Status changed from assigned to closed

Thanks Sravani,

I ran a query against the epic_billing_diag_discharge view with production data and it completed in what I consider to be a reasonable amount of time (<30 seconds):

select count(*) from epic_billing_diag_discharge;

Merged in [27acba45d38c].

comment:9 follow-up: Changed 3 years ago by dconnolly

  • Keywords public-web added

comment:10 in reply to: ↑ 9 Changed 3 years ago by mhoag

  • Sensitive unset

In comment:9 this was marked as public-web so I will removing the sensitive flag. Nathan (owner) confirmed over my shoulder.

Note: See TracTickets for help on using tickets.